Changed selectedImage from index based to id based

This helps keep the selection after reordering
WordPress · Sep 30, 2018 · f070faf · f070faf
1 parent fff6f87
commit f070faf
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/block-library/src/gallery/edit.js b/packages/block-library/src/gallery/edit.js
@@ -65,11 +65,11 @@ class GalleryEdit extends Component {
 		};
 	}
 
-	onSelectImage( index ) {
+	onSelectImage( imageId ) {
 		return () => {
-			if ( this.state.selectedImage !== index ) {
+			if ( this.state.selectedImage !== imageId ) {
 				this.setState( {
-					selectedImage: index,
+					selectedImage: imageId,
 				} );
 			}
 		};
@@ -272,10 +272,10 @@ class GalleryEdit extends Component {
 								alt={ img.alt }
 								id={ img.id }
 								dragId={ imageId }
-								isSelected={ isSelected && this.state.selectedImage === index }
+								isSelected={ isSelected && this.state.selectedImage === imageId }
 								index={ index }
 								onRemove={ this.onRemoveImage( index ) }
-								onSelect={ this.onSelectImage( index ) }
+								onSelect={ this.onSelectImage( imageId ) }
 								setAttributes={ ( attrs ) => this.setImageAttributes( index, attrs ) }
 								caption={ img.caption }
 							/>