Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change dropdown button label to 'screen options.' #63031

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Fix: Change dropdown button label to 'screen options.' #63031

wants to merge 3 commits into from
+2 −2

Conversation

vipul0425
Copy link
Contributor

What?

Fixes: #63029

Testing Instructions

  • Go to the Site Editor > Pages.
  • At the top of the pages list, hover or focus the View Options icon button.
  • Observe the button label should be... Screen options.
  • test with languages other than English, Spanish or Italian and please report in the comments below all the incorrect translations you may find.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices [Package] DataViews /packages/dataviews labels Jul 1, 2024
@tyxla tyxla mentioned this pull request Jul 3, 2024
Open
tyxla
tyxla reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @vipul0425 🙌

Let's hold off merging this as #63029 still needs consensus on whether this is the best way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices [Package] DataViews /packages/dataviews [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Views: Rename 'View Options` control to 'Screen Options'
3 participants
@vipul0425 @tyxla @amitraj2203