Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size presets inconsistent with the global fluid typography setting. #64765

Closed
2 tasks done
matiasbenedetto opened this issue Aug 23, 2024 · 0 comments · Fixed by #64803
Closed
2 tasks done

Font size presets inconsistent with the global fluid typography setting. #64765

matiasbenedetto opened this issue Aug 23, 2024 · 0 comments · Fixed by #64803
Assignees
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Aug 23, 2024

Description

The font size preset UI is inconsistent regarding the global fluid typography setting. If the setting is not enabled, the fluid typography UI is still available to users, but the saved settings have no impact on the frontend because the fluid settings make no impact when the "fluid":true isn't set in the settings.typography path of the theme.json file.

Fixing this issue is an alternative to another issue: make the 'local' fluid setting work despite the global one. Depending on the decision on #64766 Should a particular 'fluid' setting of a font size preset work if the global typography.fluid setting is not set or is false? we can close this issue as not valid.

Step-by-step reproduction instructions

  1. Use or create a theme without the "fluid":true set in the settings.typography path of the theme.json file.
  2. Navigate to the typography settings of the editor.
  3. Enter the font size presets and edit a font size preset.
  4. Check that you can mark the fluid option of the font size preset.

This isn't consistent because despite adding those settings, they won't impact the rendering of the font sizes because the global fluid is not set.

Screenshots, screen recording, code snippet

image

Environment info

  • Gutenberg trunk
  • WordPress 6.6.1

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@matiasbenedetto matiasbenedetto added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Typography Font and typography-related issues and PRs labels Aug 23, 2024
@matiasbenedetto matiasbenedetto self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant