Fixes the default fluid value on the UI based on the global typography fluid value. #64803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Type] Bug
matiasbenedetto
changed the title
|
Size Change: -3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 27, 2024
t-hamano
reviewed
Aug 27, 2024
| // Whether fluid is true or an object, set it to true, otherwise false. | ||
| const isFluid = !! fontSize.fluid ?? false; | ||
| // Whether the font size is fluid. If not defined, use the global fluid value of the theme. | ||
| const isFluid = |
There was a problem hiding this comment.
Sorry for the late review. I noticed that it was already merged, but I'll comment just in case.
settings.typography.fluid is not necessarily a boolean value, but can be an object. That is, if the following theme.json is defined, isFluid will be an object:
{
"settings": {
"typography": {
"fluid": {
"minFontSize": "16px"
},
"fontSizes": [
{
"name": "Theme font size 1",
"size": "30px",
"slug": "theme-1"
}
]
}
},
"version": 3
}We might want to change it to the following to ensure that isFluid is always a boolean value:
fontSize.fluid !== undefined ? !! fontSize.fluid : !! globalFluid;However, the current implementation works fine for now.
There was a problem hiding this comment.
Good point, thanks for catching.
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…fluid value (WordPress#64803) Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the default fluid value on the UI based on the global typography fluid value.
Why?
This PR makes the UI consistent with the default behavior of the fluid typography settings. If the global fluid setting
settings.typography.fluidis defined astrue,all the font size presets are rendered as fluid despite not being set asfluidexplicitly. This PR reflects that in the UI.Fixes: #64765
How?
Considers the global fluid typography option to render and display the control correctly.
Testing Instructions
{ "settings": { "typography": { "fluid": true, "fontSizes": [ { "name": "Theme font size 1", "size": "30px", "slug": "theme-1" } ] } }, "version": 3, "$schema": "https://schemas.wp.org/trunk/theme.json" }fluidcontrol should be rendered as true, and without this PR, it should render (incorrectly) as false.Screenshots or screencast
Despite the
fluidoption not being explicitly defined in the font size preset, the UI will be checked because the behavior will be true because the global option is enabled.{ "settings": { "typography": { "fluid": true, "fontSizes": [ { "name": "Theme font size 1", "size": "30px", "slug": "theme-1" } ] } }, "version": 3, "$schema": "https://schemas.wp.org/trunk/theme.json" }