Make colors for calendar optional #29731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -30 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
7 tasks
|
This makes sense but the reason I didn't do it this way was that I was concerned about backwards compatibility - themes that don't opt in to block styles or provide their own defaults for the calendar would break. |
|
Let's close this as it didn't get enough support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #29714
The calendar block has more design surface than most blocks: header, contents with the table, borders, etc. All of those parts can be styled quite differently depending on theme choices. The current block CSS is of the opinion that the header should use a color along the lines of the border and content. This makes it slightly more difficult for themes to style (specificity) and when users set the text and background color globally, there're some weird results.
This PR does the following:
wp-block-styles.Alternatively, we could remove the colors entirely. I think the issue #29714 highlights is bigger, though. I'll comment there. I'm not sure this PR is a good idea or not, but thought I'd share to gather feedback anyway.
In
trunk:With this PR:
How to test
add_theme_support( 'wp-block-styles' );in functions.php, so the theme doesn't opt-in into theme.scss styles.