Navigator: add basic location history
#37416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
|
Size Change: +75 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/navigator-add-location-history
branch
from
28b64a7 to
86db45f
Compare
youknowriad
reviewed
Dec 17, 2021
| // previous and the new location. | ||
| // Also force the `isInitial` flag to `false` for the new location, to make | ||
| // sure it doesn't get overridden by mistake. | ||
| setLocationHistory( [ |
There was a problem hiding this comment.
I think we should add a limit to this array (like 10 items or so)
There was a problem hiding this comment.
What would be the motivation for it?
Adding a limit would have a few consequences. Let's say the limit is 10 — it means that, when we navigate to the 11th location, we would either:
- prevent any further navigation (since the stack is full). This approach doesn't seem very viable in terms of UX, since it would suddenly prevent the user from navigating to another screen. OR
- drop the initial root location, and make the second location in the array the new "root". This would introduce further complexity in the code (shifting the array, re-setting the
isInitialprop, ...) and it would also mean that the user wouldn't be able to navigate back all the way to the initial route.
I personally think that, rather than enforcing a hard limit on the array, we should tackle this potential issue by making sure that our UIs are not designed to require too many levels of "screen nesting" in the first place.
There was a problem hiding this comment.
Hey @youknowriad , do you have any additional thoughts on my previous answer?
There was a problem hiding this comment.
Sorry I didn't reply here. I was just thinking about memory leaks but as you said, it might not grow much so fine by me.
There was a problem hiding this comment.
That's fine, thank you!
ciampo
force-pushed
the
feat/navigator-add-location-history
branch
from
310ea40 to
b8abecd
Compare
youknowriad
approved these changes
Jan 21, 2022
7 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the conversation in #37063 and the exploratory work done in #37223, this PR is the first step towards adding support for advanced focus restoration in
Navigator. The plan is to have the work split across 3 PRs:NavigationLinkandNavigationBackLinkcomponents (future PR)This PR adds a basic implementation of location history to the
Navigatorcomponent.Navigatorcomponent, especially the shape of the context object: it now exposeslocation(the current location),push(used to navigate to a new location), andpop(used to navigate to the previous location)How has this been tested?
Screenshots
Storybook
navigator-focus-restoration.mp4
Preferences Modal
preference-modal-focus-restoration.mp4
Global Styles Sidebar
global-styles-sidebar-focus-restoration.mp4
Types of changes
New feature (technically not breaking, since the component is experimental)
Checklist:
*.native.jsfiles for terms that need renaming or removal).