Theme JSON: adding optional argument to get_style_nodes() #41218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding an optional, second
$selectors
argument toget_style_nodes()
to match the original function signature in 5.9.Props to @torounit, who discovered the bug and came up with the original fix in #41217
This PR includes an additional type check in
filter_out_block_nodes()
to avoid the PHPCodeSniffer error:Why?
#41160 refactored
get_style_nodes()
so that the$selectors
argument was no longer required. This was incompatible with the original method in 5.9.How?
Adding an optional
$selectors
argument to keep the linters happy.Testing Instructions
Fire up this branch and run through the testing scenarios in #41160
Ensure you don't encounter the error: