Allow post title block to use a <p> element #42590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Post Title
|
Size Change: +179 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
@carolinan I am not sure this is a great idea. Do you not think users will just select p for single post template and break accessibility? I think this might be a mistake without detection logic to ensure we nudge users in the right direction. |
|
The default is the H2. I think the risk that a user would change it to a p tag inadvertently is low. I am not sure how to detect if the block is placed on a single template -and a query loop with a list of other posts, on a single template, is not invalid. 🤔 For the use case in the issue, isn't a list with linked paragraphs more accessible than a list that contains linked headings but no other text? The headings wouldn't be actual headings above content. |
|
I cannot speak to the accessibility concerns, but this works well and follows the implementation in the Site Title block. I think this is a great addition and actually enables people to stop using hacky workarounds. Pending any additional accessibility feedback, I would approve. |
|
Yeah, I just cannot get on board with this one. 😞 This whole issue you are trying to fix is based on context and you can argue both sides. In a list of posts, a default heading 2 is not great. However, a p tag for the post title would be even worse in my opinion. Could I suggest moving this in to a tracking issue? Then maybe we could think about how to make a better solution to cover more cases. Thanks. |
|
I did not understand what "moving into a tracking issue" means. There already is an issue, and yes, discussions can continue there. |
|
Sorry, forgot you linked the issue. Replied over there. 👍 |
carolinan
added
the
[Status] Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows the post title to use
<p>in addition to heading level 1-6.This is a proppsal for solving #30549.
Why?
Headings are not always the ideal element for the title, depending on the design.
How?
Instead of importing the heading level from the heading block, the post title now imports the level drop down and icon from the site title block, which already allows using the
<p>tag.Testing Instructions
Screenshots or screencast