Navigation Toggle unit test: unmount synchronously to cancel popover positioning #45726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #45587 which fixes the "update was not wrapped in
act()" test error in a much simpler way.Because both
NavigationToggletests are synchronous, they don'tawaitanything, all we need to do is to callumount()synchronously at the end of the test. Then thecomputePosition().then()handler that runs in the next promise tick will find the component already unmounted and will do nothing.All the tests that use
@testing-library/reactwillunmount()anyway in anafterEachhook, but that doesn't run synchronously. Jest executes the test, even a completely synchronous one, in anawaitloop like:That means the cleanup can run only after
computePosition.then(), because it loses the microtask race, which is too late:computePosition.then()already ran on a still mounted component and did an unwrapped update.I'm also removing the snapshot assertion, because we don't really need it. We test site icons being displayed.
Also removing some obsolete mocking, like the
getCurrentTemplateNavigationPanelSubMenuselector. TheNavigationTogglecomponent used that selector in the past, but it doesn't use it any longer and the tests were not updated.