Add custom attributes sources block support #51375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +486 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 987a544. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5242456031
|
|
There's currently a bug in this PR when you click For instance, now, when clicking "enter", we try to split the block into two, the first block remained externally sourced but it gets a "content" attribute filled as well (bug you can see in the code editor mode) while the second paragraph is not externally sourced. Something similar happens when pasting (you might also see two externally sourced blocks one at the beginning and one at the end) I guess we need to figure out how to address this, it feels like the ideal solution would be to not allow splitting and for pasting I'm not sure what the expected behavior should be (maybe paste as text within the block). cc @ellatrix @mtias |
|
There's a few layers to this. Eventually, I think the attribute source plus the block's interface should be dictating the "type" for a field, meaning that if we have a coupling of "content" attribute being handled by a |
49 tasks
|
This PR served its purpose as an experiment and has been implemented in other PRs. |
|
Thank you for sharing the prototype that helped to clarify further work necessary like: |
youknowriad
commented
Nov 23, 2023
| @@ -0,0 +1,110 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file is an example of frontend definition of a custom source.
youknowriad
commented
Nov 23, 2023
| * @package gutenberg | ||
| */ | ||
|
|
||
| return array( |
There was a problem hiding this comment.
And this is the definition of a custom source in the backend.
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores the possibility to allow users and extenders to flag that some block attributes come from external sources. This POC focuses on implementing the "custom fields" external source while providing a very basic API to define alternative external sources for block attributes.
For instance: this allows paragraph block to have their content sourced from a post meta.
This project have been renamed "block bindings" and you can read more details about it in #53300