DataViews: Update actions API #56026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
ntsekouras
commented
Nov 10, 2023
| - `icon`: icon to show for primary actions. It's required for a primary action, otherwise the action would be considered secondary. | ||
| - `isEligible`: function, optional. Whether the action can be performed for a given record. If not present, the action is considered to be eligible for all items. It takes the given record as input. | ||
| - `isDestructive`: boolean, optional. Whether the action can delete data, in which case the UI would communicate it via red color. | ||
| - `callback`: function, required. Callback function that takes the record as input and performs the required action. |
There was a problem hiding this comment.
From this line and below are the actual changes here. The rest are whitespace changes.
|
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 81dfd37. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6821856929
|
oandregal
reviewed
Nov 10, 2023
oandregal
approved these changes
Nov 10, 2023
Co-authored-by: André <[email protected]>
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
* [Data views]: Update actions API * Update packages/edit-site/src/components/dataviews/README.md Co-authored-by: André <[email protected]> --------- Co-authored-by: André <[email protected]>
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #55848 (comment)
Testing Instructions