Add more statuses to default page views #56153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +57 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Is it possible for these added views to be visible only if there are posts in them? If not, should it be? Perhaps related, have there been explorations in showing a "post count" for either of those filters? |
|
I don't mind empty views being accessible, it solves a potential "Where have all my drafts gone?!" problem, especially if there's a count like you suggest. That said, last I checked adding counts wasn't trivial, cc @ntsekouras for thoughts on that. Separately we should design nicer empty (and loading) states. It's on the todo. |
|
That's actually related to this comment:
Any thoughts? Regarding the count, it has some nuances that it would be better to handle a bit later, where we would have done more work/explorations about the proper APIs. |
|
I left a comment in that issue too, it might be better to close this PR and discuss there. Conceptually default views seem fairly practical to me, but I appreciate the UX around editing / saving them is trickier than custom views. So alternatively I'm wondering if the default views (as they appear here) could be installed as custom views when wp is itself installed (or updated). From there they'd behave just like any other custom view, IE can be edited, renamed, deleted, and so on. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds views for managing Private, Scheduled, and Pending pages.
Why?
Drafts and Trash are surfaced, it seems reasonable to include other statuses, they're particularly useful on busier sites.
Testing Instructions