Preserve the wp_theme_preview query arg when navigating in Site Editor #61394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
jsnajdr
commented
May 6, 2024
| @@ -82,9 +75,6 @@ export default function LeafMoreMenu( props ) { | |||
| { | |||
| postType: 'page', | |||
| postId: attributes.id, | |||
| ...( isPreviewingTheme() && { | |||
| wp_theme_preview: currentlyPreviewingTheme(), | |||
| } ), | |||
There was a problem hiding this comment.
Preserving wp_theme_preview no longer needs to be done explicitly like this. It is now, and should continue to be, abstracted and automated.
There was a problem hiding this comment.
Does this place need to remove the param management?
There was a problem hiding this comment.
That useLink function is also creating a URL link that can be used as an <a href> attribute. Therefore the wp_theme_preview arg needs to be added explicitly, there is no router magic that would add it automatically. That's why I'm keeping it here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +27 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
draganescu
reviewed
May 8, 2024
| @@ -82,9 +75,6 @@ export default function LeafMoreMenu( props ) { | |||
| { | |||
| postType: 'page', | |||
| postId: attributes.id, | |||
| ...( isPreviewingTheme() && { | |||
| wp_theme_preview: currentlyPreviewingTheme(), | |||
| } ), | |||
There was a problem hiding this comment.
Does this place need to remove the param management?
We'll need to think more deeply about what is the best long term solution for this. If the router has a "sticky params" setting, they need to somehow find their way also to the URLs that are not processed by the router. See the I plan to continue working on this, this PR is just a good-enough hotfix so that the Theme Preview feature is not broken for too long. |
|
Apparently I broke e2e tests, like this one: There are links that have an empty |
jsnajdr
force-pushed
the
fix/theme-activation-query-param
branch
from
ad13f80 to
4180577
Compare
|
@draganescu I fixed the e2e failures (caused by bad |
draganescu
approved these changes
May 9, 2024
There was a problem hiding this comment.
Let's get this in as it fixes the big problem.
Stumbled upon another smaller problem, which may have been in before any change:
- when previewing
- after activating a theme
- clicking browser back
- brings the activate button back, which is wrong b/c the theme is already active
⬆️ this needs to be a separate issue, not blocking here.
Thank you for the quick help @jsnajdr
Nice find, though in this case it's not a regression caused by #60466, it existed before. If you click browser back button after theme activation, the URL changes from one that doesn't have A possible fix is to detect the case where we're previewing the currently active theme. In that case all the "Activate ..." buttons have no function and we should be redirected to plain Site Editor, without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61239, a bug where the
wp_theme_previewquery param is not preserved when navigating around Site Editor in "Activate theme" mode.It's a regression I commited in #60466, stopping to preserve query params automatically.
This fix is a not very good "temporary" hotfix. It's not a good solution to patch the router package, but I haven't found any other so far and I want to make the feature work again quickly.
How to test:
wp_theme_preview=theme-slugquery param.