Pass content property to onInput in useEntityBlockEditor #61496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
I started this pull request trying to solve an issue found in this other one. However, it took a different approach. Additionally, it seems the e2e tests were failing. I'm closing this pull request, but I'm happy to reopen it if we think it still makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As discussed here, onInput should probably pass the content property, which marks the post dirty.
Why?
To avoid unexpected issues like not having an undo option or updating the save button in some cases like this one.
How?
Copying and pasting the solution for
onChange.Testing Instructions
Check if tests pass.