-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Show a preview when dragging and dropping patterns from the inserter. #61511
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
0d5cfef
to
0f4b4d4
Compare
Size Change: +1.65 kB (+0.09%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as intended, I updated the changelog and pinged some component maintainers
We need to find a different handling for this because right now the browser takes a screenshot and can include the pattern's title and hover styles, which is not what we want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find a different handling for this because right now the browser takes a screenshot and can include the pattern's title and hover styles, which is not what we want.
I will close this because no progress and also because we use the chip in all the other places. |
What?
When dragging and dropping patterns from the inserter we now show a preview of the pattern instead of the draggable chip.
Why?
This will be more user friendly and easier for users to understand what they are doing.
How?
Just let the browser handle the preview.
Testing Instructions
Screenshots or screencast