Convert blob package to TypeScript #61541
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jpstevens! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Mamaduka
added
[Type] Enhancement
| @@ -1,7 +1,9 @@ | |||
| type BlobPart = BufferSource | Blob | string; | |||
There was a problem hiding this comment.
BlobPart should be a native built-in type, after all, it's used in the Blob constructor. You don't need to define it here.
| /** | ||
| * @type {Record<string, File|undefined>} | ||
| */ | ||
| const cache = {}; | ||
| const cache: Record< string, File | undefined > = {}; |
There was a problem hiding this comment.
I think the cache type should be Record< string, File >. We never intentionally store undefined values.
There was a problem hiding this comment.
Also, we can remove all of the JSDoc type annotations.
|
👋 @jpstevens Thanks for this! If you'll update this PR on the latest |
What?
This PR converts the
blobpackage to TypeScript.Why?
Ensures package is fully type checked.
How?
.tsindexfile@ts-ignorestatements to tests that call functions in ways that are not type-compliantTesting Instructions
npm run test:unit -- packages/blobtests passnpm run build:package-typesreturns a zero exit code