Posts Dashboard: Add a new experimental empty page #62406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/posts/load.php ❔ lib/experiments-page.php ❔ lib/load.php |
fabiankaegy
approved these changes
Jun 7, 2024
|
I'd be up for a label but not "Admin Redesign", I'd do more "Posts Dashboard" or something. "Admin Redesign" would be too broad to me. Calling @annezazu the expert of labels just in case :) |
|
Size Change: +1.96 kB (+0.11%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
added
the
[Feature] Posts/Tags/Categories Screen
|
Ok I added a label for now, feel free to edit/rename it... |
|
At first glance, I'm not sure why we need a separate label outside of using Data Views, unless we want individual labels for each spot data views is applied to. I'd want to name this label: "Applying Data Views" or "Expanding Data Views" if anything as it seems to also entail applying data views to posts, tags, and categories. Maybe even something more practical like "Data Views outside Site Editor". The current label description for "data views" talks about how the work will apply outside of the site editor and that leads me back to wanting to stick, for now, with just the Data Views label overall until the work progresses more. How does that sound? |
|
For me at least, DataViews is more about the component itself, the framework that powers all these pages while this one is more about the new WPAdmin pages that will contain both the posts, categories and tags dataviews but also their forms/editors. That said, I don't mind much whatever you all think is best, works for me. |
|
Got it! I updated it to:
With the following as the description:
This matches bringing [Feature] Widgets Screen which brought the block-based screen that replaced widgets.php and feels like an apt comparison for consistency rather than the word dashboard which is a bit loaded. If the title feels too long, I think we can go with just |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #62371
What?
This PR doesn't do much, it adds a blank page under the "Gutenberg" submenu when you enable the "posts dashboard" experiment. The idea is that it gives us a blank canvas to explore the DataViews for posts like outlined in #62371
It does make some choices:
I'm planning to reuse components and code from the site editor, so I had two choices:
I think ultimately, we'll probably end up with the former, but I don't want to create early abstractions that we'll be throwing later, so I added a new experimental function that only works in the Gutenberg plugin (tree-shaked from WordPress Core) and left it in the edit-site package for now.
Testing Instructions
1- Enable the "Posts Dashboard Experiment"
2- You'll see a "posts" page appear under the "Gutenberg" menu.
3- The page is empty for now, it just shows: "Welcome to Posts"