Rename button block attributes from url and text to href and content #62612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/blocks.php ❔ lib/compat/wordpress-6.6/blocks.php |
talldan
added
[Type] Bug
|
Size Change: +304 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
One issue is that the block bindings code in the gutenberg plugin doesn't execute when the core class is present: So that means the e2e tests for block bindings that are failing in this PR won't pass unless this change is backported. Feels like those e2e tests should be moved to wordpress core instead if they're testing core functionality. |
|
Closing based on feedback in #62133. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an attempt to solve #62133 by renaming the button block's attributes to be consistent with other blocks.
Mostly an exploration to see what it would entail (it turns out a lot of code changes, but it didn't take too long).
Why?
With block bindings and pattern overrides, the block's attributes are forming more of a schema. As described in the issue, with pattern overrides, attribute values can be shared across blocks with different types, and the values are accessed using the attribute name. When the attribute names are inconsistent for the content types they represent (like the
urlattribute name representing thesrcattribute in the image block but also thehrefattribute for a button block), it causes unexpected issues (the imagesrcending up as the button block'shrefor vice versa).How?
Rename the attributes to make these attribute schemas consistent across block types.
Testing Instructions
TBD
Screenshots or screencast