-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Bootstrap Quick Edit #63600
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e6f2e1a
DataViews: Bootstrap Quick Edit
youknowriad 07b3504
Use a toggle instead of an action
youknowriad 8455dae
Synchronize selection state with url in tables and grids
youknowriad 1e6b7bb
Update quick edit toggle
youknowriad d6e2bcf
Add empty placeholder
youknowriad 299b8bf
Single selection on row click
youknowriad f2133b8
Remove quick edit from list layout
youknowriad 662525f
Hide quick edit behind an experiment
youknowriad b2c4fdf
Change the quick edit icon
youknowriad 0e00771
Tweak spacing
youknowriad 61354e5
Small clarification
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,6 +201,17 @@ export default function Layout( { route } ) { | |
</div> | ||
) } | ||
|
||
{ ! isMobileViewport && areas.edit && ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a new routable area to address this use-case. Routes in the site editor can decide to inject UI in the "edit" area. |
||
<div | ||
className="edit-site-layout__area" | ||
style={ { | ||
maxWidth: widths?.edit, | ||
} } | ||
> | ||
{ areas.edit } | ||
</div> | ||
) } | ||
|
||
{ ! isMobileViewport && areas.preview && ( | ||
<div className="edit-site-layout__canvas-container"> | ||
{ canvasResizer } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import clsx from 'clsx'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { DataForm } from '@wordpress/dataviews'; | ||
import { useDispatch, useSelect } from '@wordpress/data'; | ||
import { store as coreDataStore } from '@wordpress/core-data'; | ||
import { Button } from '@wordpress/components'; | ||
import { useState, useMemo } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import Page from '../page'; | ||
import usePostFields from '../post-fields'; | ||
|
||
function PostEditForm( { postType, postId } ) { | ||
const { item } = useSelect( | ||
( select ) => { | ||
return { | ||
item: select( coreDataStore ).getEntityRecord( | ||
'postType', | ||
postType, | ||
postId | ||
), | ||
}; | ||
}, | ||
[ postType, postId ] | ||
); | ||
const { saveEntityRecord } = useDispatch( coreDataStore ); | ||
const { fields } = usePostFields(); | ||
const form = { | ||
visibleFields: [ 'title' ], | ||
}; | ||
const [ edits, setEdits ] = useState( {} ); | ||
const itemWithEdits = useMemo( () => { | ||
return { | ||
...item, | ||
...edits, | ||
}; | ||
}, [ item, edits ] ); | ||
const onSubmit = ( event ) => { | ||
event.preventDefault(); | ||
saveEntityRecord( 'postType', postType, itemWithEdits ); | ||
setEdits( {} ); | ||
}; | ||
|
||
if ( ! item ) { | ||
return null; | ||
} | ||
|
||
return ( | ||
<form onSubmit={ onSubmit }> | ||
<DataForm | ||
data={ itemWithEdits } | ||
fields={ fields } | ||
form={ form } | ||
onChange={ setEdits } | ||
/> | ||
<Button variant="primary" type="submit"> | ||
{ __( 'Update' ) } | ||
</Button> | ||
</form> | ||
); | ||
} | ||
|
||
export function PostEdit( { postType, postId } ) { | ||
return ( | ||
<Page | ||
className={ clsx( 'edit-site-post-edit', { | ||
'is-empty': ! postId, | ||
} ) } | ||
label={ __( 'Post Edit' ) } | ||
> | ||
{ postId && ( | ||
<PostEditForm postType={ postType } postId={ postId } /> | ||
) } | ||
{ ! postId && <p>{ __( 'Select a page to edit' ) }</p> } | ||
</Page> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
.edit-site-post-edit { | ||
padding: $grid-unit-30; | ||
|
||
&.is-empty .edit-site-page-content { | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to clear the existing selection when the user clicks the row? This means that we'd have two affordances (checkbox & row click) that work differently:
Gravacao.do.ecra.2024-07-22.as.13.22.15.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. See #63600 (comment) and the following comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is intentional #63600 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where this is coming from: we want to optimize for the quick edit flow, otherwise it's quite cumbersome 👍