Merge 63406 (Navigation block: Allow themes to override block library text-decoration rule) into wp/6.6 branch #63641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion rule (#63406) * Reduce specificity of navigation text decoration rule * Apply Aaron suggestion to also lower specificity for focus/active * Remove `:not([class*="has-text-decoration"])` from selector ---- Co-authored-by: talldan <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
andrewserong
added
[Type] Bug
|
Size Change: -49 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks for wrangling this one @andrewserong 👍
✅ Code changes match #63406
✅ Nav block text decoration tests well in both editor and frontend
LGTM 🚢
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Not all that familiar with the CSS specificity work but I I followed the testing steps in #63406 and it functioned as expected 👍 |
|
It's auto cherry-picked, but thanks for the PR and approvals! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR proposes merging "Navigation block: Allow themes to override block library text-decoration rule (#63406)" into the
wp/6.6branch.Why?
A separate PR is used here so that we have a clean build of the
wp/6.6branch with this change applied on top of it, and can download a zip file of the generated artefact.How?
Checked out the
wp/6.6branch, and cherry picked the merge commit from #63406 into this branch.Testing Instructions
Follow the testing instructions in #63406