WIP: Fix infinite render of pattern block from call to setBlockEditingMode
#63928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @htmgarcia. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
commented
Jul 25, 2024
Comment on lines
+2166
to
+2168
| if ( select.getBlockEditingMode( clientId ) === mode ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is what fixes the bug.
talldan
commented
Jul 25, 2024
| ? 'disabled' | ||
| : undefined | ||
| ); | ||
| registry.batch( () => { |
There was a problem hiding this comment.
I figured this should use registry.batch? Was it originally an oversight or is it unnecessary?
talldan
commented
Jul 25, 2024
| @@ -74,18 +74,19 @@ const useInferredLayout = ( blocks, parentLayout ) => { | |||
| }, [ blocks, parentLayout ] ); | |||
| }; | |||
|
|
|||
| function setBlockEditMode( setEditMode, blocks, mode ) { | |||
| function updateInnerBlocksEditingMode( blocks, mode, setBlockEditingMode ) { | |||
There was a problem hiding this comment.
I made some other changes here, as I found the naming of this function (which was very similar to setBlockEditingMode) too confusing to read. Also made some other small readability changes.
|
Actually, this doesn't fix it, it's just that I'd messed up dispatching the action. |
|
Size Change: +46 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
changed the title
setBlockEditingModesetBlockEditingMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP
Fixes #63909
Why?
How?
Then follow these steps:
In trunk: The pattern and verse block infinitely re-render causing the editor to hang
In this PR: The editor is usable