Fix Modal’s dismiss effect in StrictMode #64075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jul 30, 2024
| @@ -89,8 +89,7 @@ function useEditorCommandLoader() { | |||
| name: 'core/open-shortcut-help', | |||
| label: __( 'Keyboard shortcuts' ), | |||
| icon: keyboard, | |||
| callback: ( { close } ) => { | |||
| close(); | |||
There was a problem hiding this comment.
Do we want to keep the Command Palette modal open alongside the shortcuts and preferences modal? Most of the commands I checked call the close callback.
There was a problem hiding this comment.
(Non-nested) Modal’s already can’t be open alongside each other. It doesn’t hurt anything to keep calling the close callback but I figured why not remove it now that the malfunction it works around is fixed.
There was a problem hiding this comment.
Calling close() here is actually a good idea, because the command palette modal closes itself explicitly.
Otherwise it's auto-closed by the newly opened modal: they are at the same context level, they are not nested, so only one can be open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A bug fix and follow up to #64019 which worked around the issue #64004 where in StrictMode an effect can force a Modal to dismiss itself immediately.
Why?
The effect to dismiss other Modal’s should work properly whether or not StrictMode is active.
How?
Testing Instructions
WP_DEBUG = trueandSCRIPT_DEBUG = true.Testing Instructions for Keyboard
Screenshots or screencast
modal-dismissage.mp4