CustomSelectControl: Add lint rule for 40px size prop usage #64559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Aug 15, 2024
| @@ -129,6 +129,7 @@ function NonDefaultControls( { format, onChange } ) { | |||
| return ( | |||
| <VStack> | |||
| <CustomSelectControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Seen in the Date block.
| Before | After |
|---|---|
 |
 |
| @@ -150,6 +152,7 @@ export default function FontAppearanceControl( props ) { | |||
| <CustomSelectControl | |||
| { ...otherProps } | |||
| className="components-font-appearance-control" | |||
| __next40pxDefaultSize={ __next40pxDefaultSize } | |||
There was a problem hiding this comment.
This was already passed through via otherProps, but making it explicit here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
28 tasks
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 16, 2024
ciampo
reviewed
Aug 16, 2024
| @@ -39,6 +39,8 @@ const getFontAppearanceLabel = ( hasFontStyles, hasFontWeights ) => { | |||
| */ | |||
| export default function FontAppearanceControl( props ) { | |||
| const { | |||
| /** Start opting into the larger default height that will become the default size in a future version. */ | |||
| __next40pxDefaultSize = false, | |||
There was a problem hiding this comment.
Should we add FontAppearanceControl to the lint rule too? Or at least a TODO comment to update this in the future?
There was a problem hiding this comment.
Hmm, good point 🤔 I'll go back and batch add the affected wp-block-editor components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Add a lint rule to prevent people from introducing new usages of CustomSelectControl that do not adhere to the new default size.
Testing Instructions
The lint error should trigger for violations as expected.