Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageSizeControls: Replace ButtonGroup with ToggleGroupControl #65386
ImageSizeControls: Replace ButtonGroup with ToggleGroupControl #65386
Changes from 7 commits
30dbcb1
05ebec6
1196a22
e740c51
5ee7630
12532be
20d8650
393bb5d
c84ff9f
08f19cd
4979ddd
558cd41
4bc666b
a3d6c29
4fd8d34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense for the percentage string to be localized. In some languages, it might actually be displayed differently:
https://phrase.com/blog/posts/number-localization/#toc_5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we localize other percentages across Gutenberg? If not, it may be better to split it to a separate PR to localize all percentages at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think, we are localizing other percentage implementations, here is the example for column block -
gutenberg/packages/block-library/src/column/edit.js
Line 84 in 9b0f6aa
I agree with @ciampo, to add all at once, so it does not block the scope of this PR.
Thank You,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed issue #66298 regarding localizing percentage values.