Fix: Navigation open submenu on click unavailable for page-list #68462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #65513
What?
The solution automatically resets the
openSubmenusOnClick
attribute to its default state (false
) when the lastcore/navigation-submenu
block is removed from acore/navigation
block.Why?
This change addresses an issue where the "open on click" setting remains active even when no submenus are present. By resetting the attribute, we ensure the block's configuration reflects its current state accurately.
How?
The implementation uses the
useEffect
hook to monitor changes in theinnerBlocks
of thecore/navigation
block. When the inner block list is not empty and nocore/navigation-submenu
blocks are present, theopenSubmenusOnClick
attribute is set tofalse
.Testing Instructions
core/navigation
block.core/navigation-submenu
block within it.core/navigation-submenu
block.false
by switching to Code Editor.Testing Instructions for Keyboard
N/A
Screenshots or screencast
Screen.Recording.2025-01-02.at.5.30.06.PM.mov