Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove the cleanup step #839

Closed
wants to merge 1 commit into from
Closed

Remove the cleanup step #839

wants to merge 1 commit into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 1, 2022

Blocked by https://github.com/WordPress/openverse-catalog/issues/350

Fixes

Fixes WordPress/openverse#700 by @obulat
Also related to https://github.com/WordPress/openverse-catalog/issues/350

Description

This PR removes the cleanup step from the data refresh process. It can only be merged if we confirm that the data cleanup DAG had run successfully over the catalog (upstream) database (https://github.com/WordPress/openverse-catalog/issues/350).

As noted in WordPress/openverse-catalog/issues/350, data cleanup DAG wasn't run in the catalog, so there's still the data that needs cleaning in the upstream database. This PR is blocked until that issue is resolved.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Olga Bulat <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/839

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon labels Aug 1, 2022
@dhruvkb
Copy link
Member

dhruvkb commented Aug 2, 2022

If this goes well, this should also fix WordPress/openverse#699.

@zackkrida
Copy link
Member

It's great how simple this PR is 😄 As we've discussed elsewhere, this PR will be a great indicator of the success of our Data Normalization project.

@obulat
Copy link
Contributor Author

obulat commented Feb 8, 2023

Closing this PR because it's simple to re-open later. It's too early to remove the cleanup step because the data normalization steps are far from done

@obulat obulat closed this Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon ⛔ status: blocked Blocked & therefore, not ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the URL cleanup process from the ingestion server
4 participants