Apply TS suggestions from code review

Co-authored-by: sarayourfriend <[email protected]>
WordPress · Jul 12, 2023 · 1c6bcb0 · 1c6bcb0
1 parent c05250e
commit 1c6bcb0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/frontend/src/stores/media/single-result.ts b/frontend/src/stores/media/single-result.ts
@@ -193,10 +193,10 @@ export const useSingleResultStore = defineStore("single-result", {
     /**
      * Fetch the media item from the API.
      */
-    async fetchMediaItem<T extends SupportedMediaType>(
-      type: SupportedMediaType,
+    async fetchMediaItem<MediaType extends SupportedMediaType>(
+      type: MediaType,
       id: string
-    ): Promise<DetailFromMediaType<typeof type>> {
+    ): Promise<DetailFromMediaType<MediaType>> {
       this._updateFetchState("start")
       const accessToken = this.$nuxt.$openverseApiToken
       const service = initServices[type](accessToken)

diff --git a/frontend/src/types/fetch-state.ts b/frontend/src/types/fetch-state.ts
@@ -6,16 +6,6 @@ export interface BaseFetchState {
   isFinished?: boolean
 }
 
-export interface FetchState extends BaseFetchState {
-  fetchingError: null | string
-}
-
-/**
- * The fetching error has the props required for Nuxt's
- * error page.
- * TODO: replace FetchState with FetchStateWithNuxtError
- * in the provider, main media and related media stores.
- */
-export interface FetchStateWithNuxtError extends BaseFetchState {
-  fetchingError: null | NuxtError
+export interface FetchState<ErrorType = string> extends BaseFetchState {
+  fetchingError: null | ErrorType
 }