Skip to content

Commit

Permalink
Remove Storybook smoke test (#3317)
Browse files Browse the repository at this point in the history
* Remove Storybook smoke test

Signed-off-by: Olga Bulat <[email protected]>

* Remove Storybook smoke test from docs

Signed-off-by: Olga Bulat <[email protected]>

---------

Signed-off-by: Olga Bulat <[email protected]>
Co-authored-by: obulat <[email protected]>
  • Loading branch information
obulat and obulat authored Nov 7, 2023
1 parent 910cc68 commit 57fb8ec
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,9 @@ jobs:
matrix:
name:
- unit_test
- storybook_smoke_test
include:
- name: unit_test
script: "test:unit"
- name: storybook_smoke_test
script: "storybook:smoke"

steps:
- name: Checkout repository
Expand Down Expand Up @@ -546,7 +543,6 @@ jobs:
matrix:
name:
- unit_test
- storybook_smoke_test

steps:
- name: Pass
Expand Down
9 changes: 4 additions & 5 deletions documentation/meta/ci_cd/jobs/frontend.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ are
## `nuxt-checks`

Runs a matrix for various Nuxt checks for the frontend using the following
Node.js scripts.
Node.js script.

| Name | Script |
| ---------------------- | ----------------- |
| `unit_test` | `test:unit` |
| `storybook_smoke_test` | `storybook:smoke` |
| Name | Script |
| ----------- | ----------- |
| `unit_test` | `test:unit` |

This job is skipped if the frontend codebase has not changed. Its counterpart is
[`django-checks`](/meta/ci_cd/jobs/api.md#django-checks) for the API.
Expand Down
1 change: 0 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"prod:playwright": "pnpm i18n:copy-test-locales && pnpm prod",
"storybook": "nuxt storybook --port=54000",
"storybook:build": "nuxt storybook build",
"storybook:smoke": "pnpm storybook --ci --smoke-test",
"talkback": "node ./test/proxy.js",
"pretest": "pnpm install",
"test": "pnpm test:unit && pnpm test:playwright",
Expand Down

0 comments on commit 57fb8ec

Please sign in to comment.