Skip to content

Commit

Permalink
Specify amd64 platform to fix ov builds on macOS (#4932)
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvkb authored Sep 16, 2024
1 parent 849a493 commit 6b5a19c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docker/dev_env/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ shared_args=(
run_args=(
-d
--name "$container_name"
# Since we have build an amd64 image, we must specify the platform to
# suppress warnings about platform mismatch.
--platform linux/amd64
# Use host network so things like Sphinx and the frontend that run directly in `ov`
# will have ports available on the host (and this way we don't have to manually map each one)
--network host
Expand Down
3 changes: 2 additions & 1 deletion ov
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ init)
;;

build)
docker build "${@:2}" -t openverse-dev_env:latest "$dev_env"
# k6 does not install on aarch64, so we must specify the platform on macOS.
docker build "${@:2}" --platform linux/amd64 -t openverse-dev_env:latest "$dev_env"
;;

setup-env)
Expand Down

0 comments on commit 6b5a19c

Please sign in to comment.