Skip to content

Commit

Permalink
Bump Airflow version to 2.3.4 (#731)
Browse files Browse the repository at this point in the history
  • Loading branch information
AetherUnbound authored Sep 20, 2022
1 parent e66bf63 commit a329be2
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docker/airflow/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ RUN useradd -m -d ${AIRFLOW_HOME} airflow && \
chown airflow:airflow ${OUTPUT_DIR}
USER airflow

ARG AIRFLOW_VERSION=2.3.3
ARG AIRFLOW_VERSION=2.3.4
WORKDIR ${AIRFLOW_HOME}
# Always add the prod req because the dev reqs depend on it for deduplication
COPY ${REQUIREMENTS_FILE} requirements_prod.txt ${AIRFLOW_HOME}/
Expand Down
7 changes: 4 additions & 3 deletions openverse_catalog/dags/commoncrawl/commoncrawl_etl.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
EmrTerminateJobFlowOperator,
)
from airflow.providers.amazon.aws.sensors.emr import EmrJobFlowSensor
from airflow.providers.amazon.aws.sensors.s3 import S3KeySensor, S3PrefixSensor
from airflow.providers.amazon.aws.sensors.s3 import S3KeySensor
from airflow.utils.trigger_rule import TriggerRule
from common.constants import DAG_DEFAULT_ARGS
from commoncrawl.commoncrawl_utils import get_load_s3_task_id, load_file_to_s3
Expand Down Expand Up @@ -169,12 +169,13 @@
)

with dag:
check_for_cc_index = S3PrefixSensor(
check_for_cc_index = S3KeySensor(
task_id="check_for_cc_index",
retries=0,
aws_conn_id=AWS_CONN_ID,
bucket_name=COMMONCRAWL_BUCKET,
prefix=f"crawl-data/{CC_INDEX_TEMPLATE}",
bucket_key=f"crawl-data/{CC_INDEX_TEMPLATE}*",
wildcard_match=True,
poke_interval=60,
timeout=60 * 60 * 24 * 3,
soft_fail=True,
Expand Down
2 changes: 1 addition & 1 deletion requirements_prod.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# PYTHON=3.10
apache-airflow[amazon,postgres,http]==2.3.3
apache-airflow[amazon,postgres,http]==2.3.4
lxml
psycopg2-binary
requests-file==1.5.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def test_fails_if_external_dag_missing_sensor_task(self):
# TODO: warnings for...(drumroll) Airflow operators 🙃 hopefully this is
# TODO: fixed in 2.2.5 or something.
# TODO: Update: 2022-05-06/v2.3.0, still an issue!
# TODO: Update: 2022-08-15/v2.3.3, Still an issue (MJSB)
# TODO: Update: 2022-09-19/v2.3.4, Still an issue (MJSB)
warnings.simplefilter("ignore", category=DeprecationWarning)
dagbag = DagBag(dag_folder=DEV_NULL, include_examples=True)
bash_dag = dagbag.dags["example_bash_operator"]
Expand Down

0 comments on commit a329be2

Please sign in to comment.