Add the correct RTL snapshots for collection headers

frontend/test/playwright/utils/breakpoints.ts

@@ -1,26 +1,15 @@
-import { test, Expect, Page, Locator } from "@playwright/test"
+import { test } from "@playwright/test"
 
 import type { LanguageDirection } from "~~/test/playwright/utils/i18n"
 
-import { expectSnapshot as innerExpectSnapshot } from "~~/test/playwright/utils/expect-snapshot"
+import {
+  type ExpectSnapshot,
+  expectSnapshot as innerExpectSnapshot,
+} from "~~/test/playwright/utils/expect-snapshot"
 
 import { VIEWPORTS } from "~/constants/screens"
 import type { Breakpoint } from "~/constants/screens"
 
-type ScreenshotAble = Page | Locator
-
-type ExpectSnapshot = <T extends ScreenshotAble>(
-  page: Page,
-  name: string,
-  s: T,
-  config?: {
-    dir?: LanguageDirection
-    options?: Parameters<T["screenshot"]>[0]
-    snapshotOptions?: Parameters<ReturnType<Expect>["toMatchSnapshot"]>[0]
-    useColorMode?: boolean
-  }
-) => Promise<Buffer | void>
-
 type BreakpointBlock = (options: {
   breakpoint: Breakpoint
   expectSnapshot: ExpectSnapshot
@@ -95,11 +84,11 @@ const makeBreakpointDescribe =
         return `${name}${dirString}-${breakpoint}` as const
       }
 
-      const expectSnapshot = async <T extends ScreenshotAble>(
-        page: Page,
-        name: string,
-        screenshotAble: T,
-        options: Parameters<ExpectSnapshot>[3] = {}
+      const expectSnapshot: ExpectSnapshot = async (
+        page,
+        name,
+        screenshotAble,
+        options = {}
       ) => {
         const snapshotName = getSnapshotName(name, options.dir)
         return innerExpectSnapshot(page, snapshotName, screenshotAble, options)

frontend/test/playwright/visual-regression/pages/errors.spec.ts

@@ -34,7 +34,7 @@ breakpoints.describeXl(({ breakpoint, expectSnapshot }) => {
       // eslint-disable-next-line playwright/no-networkidle
       await page.waitForLoadState("networkidle")
       await expectSnapshot(page, "generic-error-ltr", page, {
-        options: { fullPage: true },
+        screenshotOptions: { fullPage: true },
       })
     })
   }
@@ -60,7 +60,7 @@ breakpoints.describeXl(({ breakpoint, expectSnapshot }) => {
       await page.waitForLoadState("networkidle")
 
       await expectSnapshot(page, "generic-error-ltr", page, {
-        options: { fullPage: true },
+        screenshotOptions: { fullPage: true },
       })
     })
   }
@@ -81,7 +81,7 @@ for (const searchType of supportedSearchTypes) {
       await goToSearchTerm(page, `SearchPage500error`, { searchType })
 
       await expectSnapshot(page, "generic-error-ltr", page, {
-        options: { fullPage: true },
+        screenshotOptions: { fullPage: true },
       })
     })
   })
@@ -106,7 +106,7 @@ for (const searchType of supportedSearchTypes) {
 
           await expectSnapshot(page, "generic-error", page, {
             dir,
-            options: {
+            screenshotOptions: {
               fullPage: true,
             },
           })

frontend/test/playwright/visual-regression/pages/pages-single-result.spec.ts

@@ -47,7 +47,7 @@ for (const mediaType of supportedMediaTypes) {
           page,
           {
             dir,
-            options: { fullPage: true },
+            screenshotOptions: { fullPage: true },
             snapshotOptions: { maxDiffPixelRatio: 0.01 },
           }
         )
@@ -70,7 +70,7 @@ for (const dir of languageDirections) {
       await sleep(500)
       await expectSnapshot(page, "full-page-report", page, {
         dir,
-        options: { fullPage: true },
+        screenshotOptions: { fullPage: true },
         snapshotOptions: { maxDiffPixelRatio: undefined, maxDiffPixels: 2 },
       })
     })

frontend/test/playwright/visual-regression/pages/pages.spec.ts

@@ -40,8 +40,8 @@ for (const contentPage of contentPages) {
           await page.mouse.move(150, 150)
           await expectSnapshot(page, contentPage, page, {
             dir,
-            options: { fullPage: true },
-            snapshotOptions: { maxDiffPixelRatio: 0.005 },
+            screenshotOptions: { fullPage: true },
+            snapshotOptions: { maxDiffPixelRatio: 0.01 },
           })
         })
       })