Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-oauth-toolkit from 2.2.0 to 2.3.0 in /api #2286

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2023

Bumps django-oauth-toolkit from 2.2.0 to 2.3.0.

Release notes

Sourced from django-oauth-toolkit's releases.

Release 2.3.0

[2.3.0] 2023-05-31

WARNING

Issues caused by Release 2.0.0 breaking changes continue to be logged. Please make sure to carefully read these release notes before performing a MAJOR upgrade to 2.x.

These issues both result in {"error": "invalid_client"}:

  1. The application client secret is now hashed upon save. You must copy it before it is saved. Using the hashed value will fail.

  2. PKCE_REQUIRED is now True by default. You should use PKCE with your client or set PKCE_REQUIRED=False if you are unable to fix the client.

Added

Changed

Changelog

Sourced from django-oauth-toolkit's changelog.

[2.3.0] 2023-05-31

WARNING

Issues caused by Release 2.0.0 breaking changes continue to be logged. Please make sure to carefully read these release notes before performing a MAJOR upgrade to 2.x.

These issues both result in {"error": "invalid_client"}:

  1. The application client secret is now hashed upon save. You must copy it before it is saved. Using the hashed value will fail.

  2. PKCE_REQUIRED is now True by default. You should use PKCE with your client or set PKCE_REQUIRED=False if you are unable to fix the client.

Added

Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner June 1, 2023 10:03
@dependabot dependabot bot requested review from krysal and dhruvkb June 1, 2023 10:03
@dependabot dependabot bot added dependencies Pull requests that update a dependency file 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Jun 1, 2023
@dependabot dependabot bot force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch from 5e3abbf to 82d266b Compare June 1, 2023 16:30
@dhruvkb
Copy link
Member

dhruvkb commented Jun 2, 2023

This breaks nearly half of the API test suite so it'll take quite a bit of work before it can be merged.

@krysal krysal marked this pull request as draft June 5, 2023 14:57
@dependabot dependabot bot force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch 2 times, most recently from a2e83b8 to d3e313a Compare June 6, 2023 12:53
@obulat
Copy link
Contributor

obulat commented Jun 6, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch from d3e313a to 7c8252d Compare June 6, 2023 13:44
@sarayourfriend
Copy link
Collaborator

@krysal @dhruvkb can y'all update on the status of this PR? Is this update possible or do we need additional changes to make it happen?

@zackkrida zackkrida assigned zackkrida and krysal and unassigned zackkrida Jun 27, 2023
@zackkrida
Copy link
Member

@sarayourfriend, @krysal is going to investigate the test failures this week.

@krysal
Copy link
Member

krysal commented Jul 3, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch from 7c8252d to b53bd56 Compare July 3, 2023 16:33
Bumps [django-oauth-toolkit](https://github.com/jazzband/django-oauth-toolkit) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/jazzband/django-oauth-toolkit/releases)
- [Changelog](https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md)
- [Commits](jazzband/django-oauth-toolkit@2.2.0...2.3.0)

---
updated-dependencies:
- dependency-name: django-oauth-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@krysal krysal force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch from b53bd56 to 42575e7 Compare July 7, 2023 16:11
@github-actions github-actions bot added the migrations Modifications to Django migrations label Jul 7, 2023
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed labels Jul 7, 2023
@krysal krysal force-pushed the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch from 42575e7 to e0f1a1e Compare July 7, 2023 16:32
@WordPress WordPress deleted a comment from github-actions bot Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced.

@krysal krysal marked this pull request as ready for review July 7, 2023 16:39
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration was missing. Now looks good.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice find with the migration!

@krysal krysal merged commit 06ccd92 into main Jul 7, 2023
48 checks passed
@krysal krysal deleted the dependabot/pip/api/django-oauth-toolkit-2.3.0 branch July 7, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users migrations Modifications to Django migrations 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐍 tech: python Involves Python
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants