Remove duplicated plausible props #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
|
Size Change: -165 B (0%) Total Size: 832 kB
ℹ️ View Unchanged
|
sarayourfriend
requested changes
Jul 6, 2023
sarayourfriend
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
LGTM!
I realised when re-reviewing that language could be derived from the built-in page, as we can derive the locale from locale prefix (or en if there isn't one). It's probably easier to query along those lines too because you can't combine custom prop filters to see, for example, if a "load more" events on image queries happen less for users of the RTL version of the site than LTR, because you couldn't query against both mediaType and language. However, you can filter page using wildcards, so you could filter, for example, event:page=/ar*&event:name=LOAD_MORE_RESULTS&event:props:mediaType=image to grab the event when it happened on the Arabic version of the site.
Anyway, not a blocker, but if you think it's worth removing and adding documentation to this effect somewhere, another issue would be good.
dhruvkb
approved these changes
Jul 10, 2023
I can't find anything relating to this from Plausible! I'll ask them and create a new issue. |
All of this is documented here, isn't it? https://plausible.io/docs/stats-api#properties (Linked in the issue, by the way) Timestamp is the only think missing, as far as I can tell, but you can't query against timestamps directly from Plausible's API. |
|
That's perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2534 by @sarayourfriend
Description
Removes custom props added as defaults to all plausible events in favor of corresponding default values already provided by plausible.
Testing Instructions
Read the issue and make sure the removed events are correct. All tests should pass.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin