Add Playwright visual regression tests for error pages #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟧 priority: high
|
Size Change: 0 B Total Size: 829 kB ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
LGMT. Just to clarify "the snapshots show problems with inconsistency" that you mentioned, is the CSR single result error page being blank part of that? I wish there was a way to record that a snapshot was recording a bug rather than recording the intended behaviour/presentation.
Regardless, LGTM, glad we have these. It really helps to have these for bugs too because it enforces the idea of writing the test to reproduce the bug before fixing the bug 🙂
Yes, I meant exactly that, @sarayourfriend. The error pages on CSR should also show the yellow error page (and they do, in #2585 :) ) |
obulat
force-pushed
the
add/error_pages_vr_tests
branch
from
2a8660f
to
fe6c394
Compare
|
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @dhruvkb Excluding weekend1 days, this PR was ready for review 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
obulat
force-pushed
the
add/error_pages_vr_tests
branch
from
fe6c394
to
61bd555
Compare
Fetching search results/single media results CSR / SSR 404, 429, 500
obulat
force-pushed
the
add/error_pages_vr_tests
branch
from
61bd555
to
0b739e8
Compare
zackkrida
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2610 by @obulat
Description
To simulate the errors on the server, we use mock tapes that have the specific errors we need.
To simulate the errors on the client, we use Playwright's
page.routefunction.This PR adds the snapshot tests for the following scenarios:
The snapshots show the problems we currently have in the error pages: the pages we show are not always consistent with the actual problem that the app encountered.
Testing Instructions
The CI should pass and the code should make sense.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin