Blur sensitive search results #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
|
Size Change: +1.88 kB (0%) Total Size: 831 kB
ℹ️ View Unchanged
|
obulat
reviewed
Jul 14, 2023
| :alt="image.title" | ||
| :class="[ | ||
| isSquare ? 'h-full' : 'margin-auto', | ||
| { 'scale-105 blur': shouldBlur }, |
There was a problem hiding this comment.
I think we should use either blur-xl or blur-lg. Currently, some images are too clear and don't really hide the content.
There was a problem hiding this comment.
I picked a lower level of blur to help the user get a general idea of the shape of the contents of the image because with more blur, only some colour clues are left.
But I agree with your reasoning and will increase the amount.
There was a problem hiding this comment.
Is there a possibility of the genre containing anything sensitive? I don't think that is possible.
There was a problem hiding this comment.
If anything, genre will help people make a determination about whether or not they want to look at an audio file. I recommend we leave it unblurred
zackkrida
requested changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM once we use the blur values from the designs. Those were chosen carefully as part of the design approval process. According to Figma, there are two values in use:
filter: blur(60px);for imagesfilter: blur(4px);for text in the audio components (author, title)
github-actions
bot
added
the
🧱 stack: documentation
|
I messed up, I forgot to look up the blur values in Figma. Sorry for the double reviews, it should be fixed now. |
zackkrida
approved these changes
Jul 14, 2023
|
Full-stack documentation: https://docs.openverse.org/_preview/2640 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
13 tasks
obulat
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2369 by @dhruvkb
Description
This PR adds logic to the image and audio result components to blur their content if their media item has been flagged as sensitive. It also replaces title and creator strings from the DOM with placeholders to prevent any sensitive information from leaking through assistive technology that bypasses CSS and interacts with the DOM.
Testing Instructions
fake_sensitivetoggle in the/preferencespage.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin