-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nuxt eslint module #2643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Size Change: 0 B Total Size: 829 kB ℹ️ View Unchanged
|
Full-stack documentation: https://docs.openverse.org/_preview/2643 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good riddance
Fixes
Fixes #2633 by @sarayourfriend
Description
This PR removes the eslint module from Nuxt app and greatly improves the DX 🎉 For more info, see the related issue.
Testing Instructions
Try duplicating a JS import in one of the components, or adding an unused import. Then, run
just frontend/run dev
. On main, you wouldn't be able to run the app because it would show an error screen. In this PR the app should run normally. However, if you try to commit these changes, pre-commit would prevent you from doing that.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin