-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensitivity toggles in filter sidebar and modal #2672
Conversation
Size Change: +720 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
frontend/src/components/VHeader/VHeaderMobile/VContentSettingsModalContent.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one typo which concerns accessibility but otherwise LGTM. This is awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and works as-expected locally! I have a few mostly questions, one comment on phrasing but nothing to block a merge 🚀
Co-authored-by: Zack Krida <[email protected]>
Full-stack documentation: https://docs.openverse.org/_preview/2672 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Fixes
Fixes #2368 by @dhruvkb
Description
This PR adds toggles in the sidebar to control the fetching and blurring of sensitive content.
The next step for the project would be to link the first toggle with the search store's filter mechanism so that changing it applies the right query params in the search request, i.e. #2548
Testing Instructions
fake_sensitive
andsensitive_content
flags. The former ensures there is some content to test blurring with and the latter controls the visibility of the toggles.fetch_sensitive
feature flag. Toggle it to see the session storage value change.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin