useSensitiveMedia composable #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +168 B (0%) Total Size: 837 kB
ℹ️ View Unchanged
|
zackkrida
added
🟧 priority: high
obulat
reviewed
Jul 22, 2023
obulat
reviewed
Jul 22, 2023
obulat
requested changes
Jul 22, 2023
There was a problem hiding this comment.
Thank you for extracting these changes, they are really fun! They work well, but I found a problem with implementation, and one suggestion on possible simplification using Set.
The biggest blocker is the uiStore watcher that is called by every component using use-sensitive-media composable.
…d sensitive uuids on blur toggle
Co-authored-by: Olga Bulat <[email protected]>
10 tasks
obulat
approved these changes
Jul 24, 2023
dhruvkb
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #2462 by @dhruvkb
Description
This PR creates a new
useSensitiveMediacomposable for working with sensitive media, and updates the blurring logic to use this composable. This composable is fully tested with a unit test, and forms the basis of the "backend" work for the single result sensitivity UI. It includes hide/reveal methods that aren't used by this PR but will be for the VSafetyWall.This PR also adds revealedSensitiveResults, a list of UUIDs of revealed sensitive media, to the UI store.
It was extracted into a standalone PR for ease of reviewing.
Testing Instructions
Check that blurring still works as-expected in the frontend search results, when all relevant
/preferencestoggles are enabled. Check that you like theuseSensitiveMediaimplementation and that test coverage is sufficient.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin