Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch Airflow provider #3366

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

AetherUnbound
Copy link
Collaborator

Fixes

Fixes #2370 by @AetherUnbound

Description

This PR adds the Elasticsearch Airflow provider package to our catalog Docker image. In order for the package to be available for use in DAGs, we'll need to deploy the catalog once this is merged.

Testing Instructions

  1. just build && just api/init
  2. just catalog/ipython
  3. Run:
    from airflow.providers.elasticsearch.hooks.elasticsearch import ElasticsearchPythonHook
    hook = ElasticsearchPythonHook("http://es:9200")
    hook.get_conn.indices.get_alias(index="*")

You should see something along the lines of:

Out[9]: ObjectApiResponse({'image-init': {'aliases': {'image': {}}}, 'audio-init-filtered': {'aliases': {'audio-filtered': {}}}, 'audio-init': {'aliases': {'audio': {}}}, 'image-init-filtered': {'aliases': {'image-filtered': {}}}})

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner November 18, 2023 00:30
@github-actions github-actions bot added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Nov 18, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Nov 18, 2023
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Confirmed with the provided instructions :)

@AetherUnbound AetherUnbound merged commit 368ec8f into main Nov 21, 2023
56 of 60 checks passed
@AetherUnbound AetherUnbound deleted the feature/elasticsearch-airflow branch November 21, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Elasticsearch Airflow Provider
5 participants