-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sources table crash #4725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🧱 stack: frontend
Related to the Nuxt frontend
🟧 priority: high
Stalls work on the project or its dependents
🛠 goal: fix
Bug fix
🕹 aspect: interface
Concerns end-users' experience with the software
labels
Aug 7, 2024
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/sources-table
branch
from
August 7, 2024 06:29
29618dc
to
145e5b7
Compare
dhruvkb
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the sorting works and clicking it multiple times does not crash anymore. It also fixes a nit I had with the production version that sorts in ascending order by default.
Co-authored-by: Dhruv Bhanushali <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/sources-table
branch
7 times, most recently
from
August 7, 2024 10:15
9a80e49
to
afefa26
Compare
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/sources-table
branch
from
August 7, 2024 10:35
afefa26
to
dde641d
Compare
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/sources-table
branch
2 times, most recently
from
August 7, 2024 11:10
ed09a32
to
53a53ae
Compare
Signed-off-by: Olga Bulat <[email protected]>
obulat
force-pushed
the
fix/sources-table
branch
from
August 7, 2024 11:29
53a53ae
to
3591474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🕹 aspect: interface
Concerns end-users' experience with the software
🛠 goal: fix
Bug fix
🟧 priority: high
Stalls work on the project or its dependents
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4724 by @obulat
Description
This PR replaces a computed for providers with a ref that is updated on a table header click.
It also changes the sorting order for the items count column: when you first click it, the items are sorted in a descending order instead of ascending order as in prod. This feels like an expected behavior for this column.
The providers data is fetched on every request in a plugin when starting the app, and is available when the user opens the sources page.
This fixes both the page hanging and the server-client mismatch that is available in production.
Testing Instructions
Go to the sources page and click on the last column header several times. The rows should be sorted, and page should not freeze. You should also not see any
client-server hydration mismatch
logs in the console.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin