-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert header-related components to script setup (23) #4763
Conversation
9bc4101
to
3739070
Compare
9aa4c46
to
f48001e
Compare
0c825af
to
0df3bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some terminal warnings for this PR:
WARN [Vue warn]: Missing required prop: "navLinkClasses"
WARN [Vue warn]: Missing required prop: "variant"
WARN [Vue warn]: Missing required prop: "isInModal"
I think it relates to how
02d7722
to
fda0987
Compare
The optional props were declared as non-optional in |
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
fda0987
to
2c9bca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes
Related to #4678 by @obulat
Description
This PR converts the header-related components to
script setup
. This is the basis for the work on combining the mobile and desktop headers.Changes
defineComponent
props
towithDefaults
anddefineProps
emits
todefineEmits
Testing Instructions
The CI should pass, and the headers should work as usual.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin