-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract VHeader
as a wrapper for header and banners
#4765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🧱 stack: frontend
Related to the Nuxt frontend
🟨 priority: medium
Not blocking but should be addressed soon
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
💻 aspect: code
Concerns the software code in the repository
labels
Aug 15, 2024
obulat
force-pushed
the
script-setup/header-components
branch
from
August 19, 2024 15:28
9aa4c46
to
f48001e
Compare
obulat
force-pushed
the
script-setup/header-components
branch
3 times, most recently
from
August 20, 2024 04:07
8ac0919
to
5d51115
Compare
obulat
force-pushed
the
add/VHeader
branch
2 times, most recently
from
August 20, 2024 05:14
a71788d
to
50c0b4b
Compare
obulat
force-pushed
the
script-setup/header-components
branch
2 times, most recently
from
August 20, 2024 15:25
0c825af
to
0df3bc9
Compare
obulat
force-pushed
the
script-setup/header-components
branch
from
August 21, 2024 05:43
02d7722
to
fda0987
Compare
obulat
force-pushed
the
script-setup/header-components
branch
from
August 21, 2024 06:54
fda0987
to
2c9bca6
Compare
obulat
force-pushed
the
add/VHeader
branch
2 times, most recently
from
August 21, 2024 18:07
93ec7ab
to
8551474
Compare
zackkrida
reviewed
Aug 21, 2024
uiStore.setHeaderHeight(height) | ||
}) | ||
|
||
const comp = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const comp = computed(() => { | |
const comp = computed(() => { |
Nit: comp is kinda overloaded with "computed" and "component": How about "headerComponent" instead?
zackkrida
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great, lgtm. I left one suggestion.
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4764 by @obulat
Description
This PR extracts
VHeader
component (wrapper over theVBanners
andVHeader<Internal|Desktop|Modal>
). This allows us to only have the height computation, saved in a CSS variable, necessary to correctly set the modal height and offset in search layout both when the banners are visible and when they are not.Testing Instructions
The CI should pass and the header should work correctly on all layouts (content pages, home page, search pages).
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin