Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract VHeader as a wrapper for header and banners #4765

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 15, 2024

Fixes

Fixes #4764 by @obulat

Description

This PR extracts VHeader component (wrapper over the VBanners and VHeader<Internal|Desktop|Modal>). This allows us to only have the height computation, saved in a CSS variable, necessary to correctly set the modal height and offset in search layout both when the banners are visible and when they are not.

Testing Instructions

The CI should pass and the header should work correctly on all layouts (content pages, home page, search pages).

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner August 15, 2024 12:55
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon 🧰 goal: internal improvement Improvement that benefits maintainers, not users 💻 aspect: code Concerns the software code in the repository labels Aug 15, 2024
@obulat obulat changed the base branch from main to script-setup/header-components August 15, 2024 12:56
@obulat obulat marked this pull request as draft August 16, 2024 07:31
@obulat obulat force-pushed the script-setup/header-components branch from 9aa4c46 to f48001e Compare August 19, 2024 15:28
@obulat obulat force-pushed the script-setup/header-components branch 3 times, most recently from 8ac0919 to 5d51115 Compare August 20, 2024 04:07
@obulat obulat force-pushed the add/VHeader branch 2 times, most recently from a71788d to 50c0b4b Compare August 20, 2024 05:14
@obulat obulat force-pushed the script-setup/header-components branch 2 times, most recently from 0c825af to 0df3bc9 Compare August 20, 2024 15:25
@obulat obulat force-pushed the script-setup/header-components branch from 02d7722 to fda0987 Compare August 21, 2024 05:43
@obulat obulat force-pushed the script-setup/header-components branch from fda0987 to 2c9bca6 Compare August 21, 2024 06:54
Base automatically changed from script-setup/header-components to main August 21, 2024 18:04
@obulat obulat force-pushed the add/VHeader branch 2 times, most recently from 93ec7ab to 8551474 Compare August 21, 2024 18:07
@obulat obulat self-assigned this Aug 21, 2024
@obulat obulat marked this pull request as ready for review August 21, 2024 18:10
uiStore.setHeaderHeight(height)
})

const comp = computed(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const comp = computed(() => {
const comp = computed(() => {

Nit: comp is kinda overloaded with "computed" and "component": How about "headerComponent" instead?

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, lgtm. I left one suggestion.

@obulat obulat merged commit 7e3ac5f into main Aug 22, 2024
43 checks passed
@obulat obulat deleted the add/VHeader branch August 22, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extract VHeader component to encapsulate duplicated code
3 participants