Convert VButton
, tabs and item group components to script setup
#4796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #4678 by @obulat
Description
This PR converts components such as
VButton
,VItemGroup
(including search types popover), tabs, and brand in the header/footer to script setup.The following conversions are done:
defineComponent
and returnsdefineProps
withwithDefaults
if necessaryscript setup
does not setoptions.name
anymore, souseComponentName
doesn't return anything. We could either adduseOptions({ name: componentName })
to the components that need the name in the analytics, or send the component name when initializing theuseSearchType
. I decided to do the latter, to explicitly pass the component name, instead of addingoptions.name
to only a handful of components that need it and making the codebase inconsistent, or adding an unnecessary options to all components.It also adds a
ZIndex
type to replace the Vue runtime validators.LoadingIcon
wasn't used, so it was removed.Testing Instructions
The CI should pass.
Also, the components affected should work correctly:
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin