Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nuxt to v3.13.1 #4869

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Update Nuxt to v3.13.1 #4869

merged 5 commits into from
Sep 5, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 5, 2024

Fixes

Description

This PR re-adds the changes for updating Nuxt to v3.13.1. I removed the changes related to i18n for easier testing.

Vue also had to be updated to the one matching this Nuxt version.
The patch release fixed the serverDir in nuxt.config, so I reverted the changes to folders for now.
I also added the recommended workaround for vue-router types.

Testing Instructions

The CI should pass, and the app should work as expected. Since the server folder was moved, it is important to check that the server routes work as usual (/healthcheck, /robots)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Sep 5, 2024
@obulat obulat requested a review from a team as a code owner September 5, 2024 09:03
@openverse-bot openverse-bot added the 🧱 stack: documentation Related to Sphinx documentation label Sep 5, 2024
@obulat obulat marked this pull request as draft September 5, 2024 09:06
@obulat
Copy link
Contributor Author

obulat commented Sep 5, 2024

Drafting because there are typing problems that we've previously seen and couldn't identify the origin: the component doesn't have $route property in this PR

Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat marked this pull request as ready for review September 5, 2024 14:14
@zackkrida
Copy link
Member

@obulat just curious why the pinia reversion was necessary. This looks good though

@obulat
Copy link
Contributor Author

obulat commented Sep 5, 2024

@obulat just curious why the pinia reversion was necessary. This looks good though

Just to minimize the number of changes in one PR, to make reverting easier if necessary

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the constrained scope.

@obulat obulat merged commit 668b43a into main Sep 5, 2024
52 checks passed
@obulat obulat deleted the update/nuxt branch September 5, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants