-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nuxt to v3.13.1 #4869
Update Nuxt to v3.13.1 #4869
Conversation
Drafting because there are typing problems that we've previously seen and couldn't identify the origin: the component doesn't have |
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
https://nuxt.com/blog/v3-13#vue-typescript-changes Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat just curious why the pinia reversion was necessary. This looks good though |
Just to minimize the number of changes in one PR, to make reverting easier if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I appreciate the constrained scope.
Fixes
Description
This PR re-adds the changes for updating Nuxt to v3.13.1. I removed the changes related to i18n for easier testing.
Vue also had to be updated to the one matching this Nuxt version.
The patch release fixed the
serverDir
innuxt.config
, so I reverted the changes to folders for now.I also added the recommended workaround for
vue-router
types.Testing Instructions
The CI should pass, and the app should work as expected. Since the server folder was moved, it is important to check that the server routes work as usual (/healthcheck, /robots)
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin