Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading skeletons #4982

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update loading skeletons #4982

merged 1 commit into from
Oct 8, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 24, 2024

Fixes

Fixes #4829 by @fcoveram

Description

This PR updates the skeleton colors to match the updated designs.

It also fixes the number of columns when the sidebar is visible: the isSidebarVisible prop wasn't passed, so the number of columns was set the same when the sidebar was open, and the screen was narrower, as when it was closed.

It also moves some styles to Tailwind classes, and simplifies the Storybook story.

Testing Instructions

Open the browser devtools and set slower speed in the "Network" tab's throttling settings.
Try searching for something in Openverse. Use some new search terms to prevent loading from cache. You should see loading skeletons. The number of columns in "All content" view should match the number of columns in the results when the filters sidebar is open (In staging, you can see that there are more columns of the skeleton than of the search results when the sidebar is open)

Check the loading skeletons in Storybook, in both dark and light modes.
Emulate prefers reduced motion using the browser devtools, and see that the skeletons are not animated.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 24, 2024 08:51
@openverse-bot openverse-bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🖼️ aspect: design Concerns related to design labels Sep 24, 2024
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/4982

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link

github-actions bot commented Sep 27, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000     ✗ 0   
     data_received..................: 1.8 GB  8.2 MB/s
     data_sent......................: 1.0 MB  4.8 kB/s
     http_req_blocked...............: avg=8.83µs   min=1.98µs  med=3.93µs   max=4.21ms  p(90)=5.37µs   p(95)=5.85µs  
     http_req_connecting............: avg=3.69µs   min=0s      med=0s       max=3.47ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=571.05ms min=54.16ms med=514.39ms max=2.57s   p(90)=1.05s    p(95)=1.16s   
       { expected_response:true }...: avg=571.05ms min=54.16ms med=514.39ms max=2.57s   p(90)=1.05s    p(95)=1.16s   
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 8000
     http_req_receiving.............: avg=151.25µs min=41.45µs med=117.24µs max=16.43ms p(90)=190.65µs p(95)=239.47µs
     http_req_sending...............: avg=22.25µs  min=6.46µs  med=19.41µs  max=7.42ms  p(90)=26.07µs  p(95)=32.8µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=570.88ms min=54.03ms med=514.25ms max=2.57s   p(90)=1.05s    p(95)=1.16s   
     http_reqs......................: 8000    36.24169/s
     iteration_duration.............: avg=3.81s    min=1.07s   med=3.15s    max=11.26s  p(90)=8.11s    p(95)=8.65s   
     iterations.....................: 1200    5.436253/s
     vus............................: 6       min=6      max=30
     vus_max........................: 30      min=30     max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida
@dhruvkb
@fcoveram
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 8 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Copy link
Contributor

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great 🚀

@obulat obulat force-pushed the update/skeleton branch 3 times, most recently from 645bdc2 to cf682be Compare October 7, 2024 19:01
@obulat obulat merged commit 214059f into main Oct 8, 2024
46 checks passed
@obulat obulat deleted the update/skeleton branch October 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update the skeleton loaders based on latest design changes
3 participants