Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS node location and add a smoke test #4996

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,27 @@ jobs:
run: |
echo '${{ matrix.image }} artifact ID is ${{ steps.upload-img.outputs.artifact-id }}'

######
# ov #
######
test-ov:
name: Run OV tests
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Initialize ov
run: |
echo "Initializing ov on ${{ matrix.os }}"
export PATH="$PATH:/Applications/Docker.app/Contents/Resources/bin/"
docker --version
./ov build
./ov init

###########
# Catalog #
###########
Expand Down
2 changes: 1 addition & 1 deletion docker/dev_env/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ENV HOME="/opt"
# location where PDM installs Python interpreters
ENV PDM_PYTHONS="${HOME}/pdm/bin"
# location where `n` installs Node.js versions
ENV N_PREFIX="${HOME}/n"
ENV N_PREFIX="${HOME}"

ENV PIPX_GLOBAL_HOME=/pipx

Expand Down
Loading