-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the preferences test more robust #5015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🧱 stack: frontend
Related to the Nuxt frontend
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Oct 2, 2024
Latest k6 run output1
Footnotes
|
obulat
added
🟧 priority: high
Stalls work on the project or its dependents
💻 aspect: code
Concerns the software code in the repository
🛠 goal: fix
Bug fix
and removed
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Oct 7, 2024
obulat
force-pushed
the
fix/#4995-attempt2
branch
6 times, most recently
from
October 7, 2024 14:45
f61685b
to
51f7669
Compare
obulat
force-pushed
the
fix/#4995-attempt2
branch
3 times, most recently
from
October 7, 2024 18:29
ae75ded
to
5344bfe
Compare
obulat
changed the title
Use only user-facing features for preferences test
Make the preferences test more robust
Oct 7, 2024
obulat
force-pushed
the
fix/#4995-attempt2
branch
from
October 7, 2024 18:56
5344bfe
to
960bec7
Compare
obulat
force-pushed
the
fix/#4995-attempt2
branch
7 times, most recently
from
October 8, 2024 08:49
44b56eb
to
81dc5f2
Compare
obulat
force-pushed
the
fix/#4995-attempt2
branch
3 times, most recently
from
October 8, 2024 10:29
cf13d4e
to
574dd42
Compare
dhruvkb
approved these changes
Oct 8, 2024
obulat
force-pushed
the
fix/#4995-attempt2
branch
2 times, most recently
from
October 8, 2024 15:02
ce24d94
to
b5351eb
Compare
obulat
force-pushed
the
fix/#4995-attempt2
branch
from
October 9, 2024 05:01
b5351eb
to
8bbf6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
🛠 goal: fix
Bug fix
🟧 priority: high
Stalls work on the project or its dependents
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #5001 by @obulat
Description
This PR updates the preferences test to make it less flaky:
getByRole
Playwright locator with thechecked
property set totrue
orundefined
. We add an extra expect, checking that the switch is enabled. This function is extracted toexpectCheckboxState
, which is added as a validexpect
to the Openverse ESLint plugin.Testing Instructions
The Playwright e2e test should pass in the CI. I will re-run this step several times to make sure that the test is not flaky.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin