Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the load test comment condition #5021

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix the load test comment condition #5021

merged 1 commit into from
Oct 7, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 7, 2024

Fixes

Fixes #5020 by @obulat

Description

This PR fixes the Run k6 frontend all against local Nuxt failure when a PR is merged to main.

Part of the action is to post the load testing results as a comment to the PR. However, when the PR is merged to main, there is no pull_request associated with the event, and the comment cannot be found.

This PR adds a step that checks that the CI is running on a pull request (and not from a fork). The commenting steps (creating the comment, finding the previous comment, and updating the comment) only run if this step's output is true.

Testing Instructions

The CI should pass (both in this PR, and when this PR is merged into main)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 7, 2024 14:33
@obulat obulat requested review from krysal and stacimc and removed request for a team October 7, 2024 14:33
@openverse-bot openverse-bot added 🧱 stack: mgmt Related to repo management and automations 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  7.9 MB/s
     data_sent......................: 1.0 MB  4.6 kB/s
     http_req_blocked...............: avg=11.96µs  min=2.12µs  med=4.09µs   max=7.89ms  p(90)=5.6µs    p(95)=6.05µs  
     http_req_connecting............: avg=5.9µs    min=0s      med=0s       max=5.79ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=592.05ms min=40.45ms med=535.59ms max=2.5s    p(90)=1.1s     p(95)=1.22s   
       { expected_response:true }...: avg=592.05ms min=40.45ms med=535.59ms max=2.5s    p(90)=1.1s     p(95)=1.22s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=153.63µs min=42.05µs med=112.63µs max=23.02ms p(90)=185.43µs p(95)=233.72µs
     http_req_sending...............: avg=22.29µs  min=6.79µs  med=19.45µs  max=3.29ms  p(90)=27.02µs  p(95)=34.52µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=591.88ms min=40.31ms med=535.4ms  max=2.5s    p(90)=1.1s     p(95)=1.22s   
     http_reqs......................: 8000    34.963043/s
     iteration_duration.............: avg=3.95s    min=1.22s   med=3.23s    max=11.66s  p(90)=8.48s    p(95)=9.03s   
     iterations.....................: 1200    5.244456/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat removed the 🧱 stack: frontend Related to the Nuxt frontend label Oct 7, 2024
@obulat obulat merged commit 64f6201 into main Oct 7, 2024
90 checks passed
@obulat obulat deleted the fix/ci-load-test branch October 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Local test local frontend step in the CI fails on merge to main
3 participants