Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only search for comments when running CI for PRs #5022

Closed
wants to merge 1 commit into from
Closed

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 7, 2024

Description

This PR fixes CI which is currently broken because the search for a specific comment fails.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner October 7, 2024 15:54
@dhruvkb dhruvkb requested review from AetherUnbound and obulat and removed request for a team October 7, 2024 15:54
@openverse-bot openverse-bot added 🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 7, 2024
@dhruvkb dhruvkb added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 7, 2024
@dhruvkb dhruvkb closed this Oct 7, 2024
@dhruvkb dhruvkb deleted the fix_ci branch October 7, 2024 16:01
Copy link

github-actions bot commented Oct 7, 2024

Latest k6 run output1

$     ✗ status was 200
      ↳  99% — ✓ 7999 / ✗ 1

     checks.........................: 99.98% ✓ 7999      ✗ 1   
     data_received..................: 1.8 GB 8.6 MB/s
     data_sent......................: 1.0 MB 4.9 kB/s
     http_req_blocked...............: avg=8.02µs   min=2µs     med=3.61µs   max=4.19ms  p(90)=5.1µs   p(95)=5.54µs  
     http_req_connecting............: avg=3.54µs   min=0s      med=0s       max=4.16ms  p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=548.65ms min=47.11ms med=492ms    max=2.3s    p(90)=1.02s   p(95)=1.13s   
       { expected_response:true }...: avg=548.54ms min=47.11ms med=491.98ms max=2.3s    p(90)=1.02s   p(95)=1.12s   
   ✓ http_req_failed................: 0.01%  ✓ 1         ✗ 7999
     http_req_receiving.............: avg=149.63µs min=40.82µs med=110.17µs max=23.31ms p(90)=183.1µs p(95)=237.02µs
     http_req_sending...............: avg=22.16µs  min=7.13µs  med=18.7µs   max=6.18ms  p(90)=25.31µs p(95)=31.33µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=548.47ms min=46.94ms med=491.86ms max=2.3s    p(90)=1.01s   p(95)=1.13s   
     http_reqs......................: 8000   37.717603/s
     iteration_duration.............: avg=3.66s    min=1.1s    med=3.12s    max=10.51s  p(90)=7.95s   p(95)=8.37s   
     iterations.....................: 1200   5.65764/s
     vus............................: 6      min=6       max=30
     vus_max........................: 30     min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants