Fix flaky e2e preferences test

[obulat]

Fixes

Fixes #5001 by @obulat

Description

The flakiness was caused by the fact that we cannot test if the preference was fixed in a robust way. Even if we detect that the switch state changed, it does not yet mean that the feature flag state was updated.

I updated the preference page to add the easily queriable state of the feature flag to the page.

Now, if we assert that the state text is correct, we can be certain that the feature flag was updated (and it wasn't only the switch update).

Testing Instructions

The CI should pass.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[github-actions]

Latest k6 run output¹

$     ✗ status was 200
      ↳  99% — ✓ 7999 / ✗ 1

     checks.........................: 99.98% ✓ 7999      ✗ 1   
     data_received..................: 1.9 GB 8.7 MB/s
     data_sent......................: 1.0 MB 4.9 kB/s
     http_req_blocked...............: avg=29.77µs  min=1.52µs  med=3.62µs   max=24.62ms p(90)=5.05µs   p(95)=5.46µs  
     http_req_connecting............: avg=25.58µs  min=0s      med=0s       max=24.58ms p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=551.66ms min=28.3ms  med=492.77ms max=2.31s   p(90)=1.02s    p(95)=1.13s   
       { expected_response:true }...: avg=551.57ms min=28.3ms  med=492.75ms max=2.31s   p(90)=1.02s    p(95)=1.13s   
   ✓ http_req_failed................: 0.01%  ✓ 1         ✗ 7999
     http_req_receiving.............: avg=142.48µs min=41.06µs med=108.02µs max=19.97ms p(90)=173.79µs p(95)=211.91µs
     http_req_sending...............: avg=19.85µs  min=7.22µs  med=18.84µs  max=2.35ms  p(90)=24.45µs  p(95)=26.62µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=551.5ms  min=28.16ms med=492.64ms max=2.31s   p(90)=1.02s    p(95)=1.13s   
     http_reqs......................: 8000   37.482996/s
     iteration_duration.............: avg=3.68s    min=1.33s   med=3.22s    max=10.68s  p(90)=8.01s    p(95)=8.48s   
     iterations.....................: 1200   5.622449/s
     vus............................: 7      min=7       max=30
     vus_max........................: 30     min=30      max=30

Footnotes

1. This comment will automatically update with new output each time k6 runs for this PR ↩

[dhruvkb]

That simplifies the logic by a lot!